fix: sync test assertion with current daily-model-inventory billing.multiplier text - #48689
Merged
Merged
Conversation
…kflow text The test `TestDailyModelInventoryWorkflowFetchesReflectInAgentPrompt` was checking for the string "the `billing.multiplier` field as the authoritative ET multiplier value" which was removed when Copilot SDK billing was added as the primary pricing source (commit 7c7febf). The workflow now says the reflect endpoint's billing.multiplier is used "to cross-check the SDK multiplier" rather than as the authoritative value. Update the test to match the current workflow text. Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
fix: update test assertion to match current daily-model-inventory workflow text
fix: sync test assertion with current daily-model-inventory billing.multiplier text
Jul 28, 2026
Copilot created this pull request from a session on behalf of
pelikhan
July 28, 2026 16:41
View session
pelikhan
marked this pull request as ready for review
July 28, 2026 16:42
Copilot stopped reviewing on behalf of
pelikhan due to an error
July 28, 2026 16:42
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot could not run the full agentic suite for this review because it was automatically requested on a bot-authored pull request. Request a review from Copilot under Reviewers to retry with the full agentic suite. Improved support for bot-authored pull requests is coming soon.
Updates the daily model inventory workflow test to reflect a change in the agent prompt language around how billing.multiplier is used.
Changes:
- Adjusted the expected prompt substring from “authoritative ET multiplier value” to “cross-check the SDK multiplier”.
Show a summary per file
| File | Description |
|---|---|
| pkg/workflow/daily_model_inventory_workflow_test.go | Updates the test assertion string to match the revised workflow prompt wording. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Low
This was referenced Jul 28, 2026
Contributor
|
🎉 This pull request is included in a new release. Release: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestDailyModelInventoryWorkflowFetchesReflectInAgentPromptwas asserting for a string that no longer exists in the workflow source after Copilot SDK billing was added as the primary pricing source.What changed
When commit
7c7febf933introduced the Copilot SDK billing job, the reflect endpoint's role was demoted from authoritative to a cross-check, and the phrasing changed:The test was never updated to match, causing it to fail on every CI run since that merge.
Fix
Updated the assertion string in
pkg/workflow/daily_model_inventory_workflow_test.goto match the current workflow text.